Repository navigation
Don't launch a kernel to permute empty arrays - #798
Merged
Merged
Conversation
maleadt
added
the
arrays
maleadt
force-pushed
the
tb/sparse-mapreduce
branch
from
October 22, 2026 10:46
48bb64d to
05b2b7c
Compare
maleadt
force-pushed
the
tb/permutedims-empty
branch
from
October 22, 2026 10:46
4705642 to
59e341b
Compare
maleadt
force-pushed
the
tb/sparse-mapreduce
branch
from
October 22, 2026 10:54
05b2b7c to
f5a2181
Compare
maleadt
force-pushed
the
tb/permutedims-empty
branch
from
October 22, 2026 10:54
59e341b to
4cef05b
Compare
maleadt
marked this pull request as ready for review
October 23, 2026 08:11
permutedims! launched its kernel with the destination's size as the ndrange, which Metal's KernelAbstractions back-end does not support when it is empty (JuliaGPU/Metal.jl#980): permutedims of an MtlMatrix with a zero dimension threw a DivideError. There is nothing to permute anyway.
maleadt
force-pushed
the
tb/permutedims-empty
branch
from
October 23, 2026 08:17
4cef05b to
7776c46
Compare
maleadt
force-pushed
the
tb/sparse-mapreduce
branch
from
October 23, 2026 08:17
f5a2181 to
725b64c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
permutedims!launched its kernel with the destination's size as thendrange. When a dimension is zero, Metal's KernelAbstractions back-end throws aDivideErrorfor that launch (JuliaGPU/Metal.jl#980), sopermutedimsof anMtlMatrixwith a zero dimension failed. There is nothing to permute, so this returns early; the comment points to the Metal issue.Tests:
permutedimsof 0×3 and 4×0×6 arrays (which only fail on Metal).Found while testing the sparse redesign (#745, stacked above) on Metal; independent of it and fine for 11.x.